Skip to content

Conversation

@MungoG
Copy link
Collaborator

@MungoG MungoG commented Oct 16, 2025

Implementation for the body_read_stream part of #55

@cppalliance-bot
Copy link

cppalliance-bot commented Oct 20, 2025

An automated preview of the documentation is available at https://57.http-io.prtest2.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2025-10-20 18:03:41 UTC

@cppalliance-bot
Copy link

cppalliance-bot commented Oct 22, 2025

An automated preview of the documentation is available at https://57.beast2.prtest3.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2025-10-22 09:45:21 UTC

void(system::error_code, std::size_t)) CompletionToken>
BOOST_ASIO_INITFN_AUTO_RESULT_TYPE(CompletionToken,
void(system::error_code, std::size_t))
async_read(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this class needs to satisfy Asio's AsyncReadStream type requirements, then the async_read function is unnecessary.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all overloads of the free function asio::async_read will work perfectly fine with this class if it meets the requirements of AsyncReadStream :
https://www.boost.org/doc/libs/master/doc/html/boost_asio/reference/async_read.html

@cppalliance-bot
Copy link

cppalliance-bot commented Oct 28, 2025

An automated preview of the documentation is available at https://57.beast2.prtest3.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2025-11-05 13:25:41 UTC

@MungoG MungoG marked this pull request as ready for review November 5, 2025 13:26
@MungoG MungoG marked this pull request as draft November 5, 2025 13:28
#include <boost/http_proto/parser.hpp>
#include <boost/system/error_code.hpp>

#include <iostream>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iostream?

#include <boost/asio/io_context.hpp>
#include <boost/asio/read.hpp>
#include <boost/buffers/buffer.hpp>
#include <boost/buffers/circular_buffer.hpp>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants